Skip to content

fix: ctx menu failure and imperative closure edge cases - #3844

Merged
isekovanic merged 1 commit into
developfrom
fix/ctx-menu-failure-and-closure-edge-cases
Oct 7, 2026
Merged

isekovanic merged 1 commit into
developfrom
fix/ctx-menu-failure-and-closure-edge-cases

Conversation

@isekovanic

Copy link
Copy Markdown
Contributor

🎯 Goal

Linear ticket: https://linear.app/stream/issue/RN-442/request-failures-and-closure-edge-cases-in-ctx-menu

This PR resolves 2 UI issues with the contextual menu:

  1. Errors on actions get all subsequent actions stuck (this happens because errors will not clear the action queue and the pending action will remain first, so if it continues failing (i.e improper permissions or something) it will block all actions following it from running as it will simply throw mid for cycle.
  2. The hardware back button (or back gesture) on Android keep the context menu open and since it overlays all of the screens it essentially keeps the opaque background while not actually closing the overlay.

πŸ›  Implementation details

🎨 UI Changes

iOS
Before After
Android
Before After

πŸ§ͺ Testing

β˜‘οΈ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@Stream-SDK-Bot

Copy link
Copy Markdown
Contributor

SDK Size

title develop branch diff status
js_bundle_size 2033 KB 2033 KB +271 B 🟑

@isekovanic
isekovanic merged commit 4de08ed into develop Oct 7, 2026
10 checks passed
@isekovanic
isekovanic deleted the fix/ctx-menu-failure-and-closure-edge-cases branch October 7, 2026 11:27
@github-actions github-actions Bot mentioned this pull request Oct 8, 2026
6 tasks
@stream-ci-bot

Copy link
Copy Markdown
Contributor

πŸŽ‰ This PR is included in version 9.9.3 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants