fix: support encoding of special characters in path params for gen2 f…#780
Draft
IzaakGough wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes firebase/firebase-functions#1459
Node.js decodes HTTP header bytes as Latin-1 by default. When Firestore (and potentially other services) send non-ASCII document paths as raw UTF-8 bytes in binary-mode CloudEvent extension attributes,
getBinaryCloudEventContextreceives them already corrupted — e.g.Helvétiosarrives asHelvétios.This is the root cause of firebase/firebase-functions#1459, which has been open since 2023 and affects all Gen2 Firestore triggers with non-ASCII document IDs.
Fix
Re-decode each header value from binary to UTF-8 before setting it on the CloudEvent:
ASCII values are unaffected (ASCII is identical in both encodings).