Skip to content

ci: restrict credentialed Custard test job to trusted refs #4382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
evilgensec wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: restrict credentialed Custard test job to trusted refs #4382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion .github/workflows/custard-run.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,19 @@ jobs:
status: failure

test:
if: needs.affected.outputs.paths != '[]'
# These tests authenticate to Google Cloud as the
# kokoro-system-test@long-door-651 service account and run repository code
# (make test -> npm install -> npm test), so they must only run on trusted
# refs. For workflow_run triggers, limit execution to same-repo branches.
# Pull requests from forks do not reach the service account credentials or
# execute their code in this privileged context; push (post-merge) and
# workflow_dispatch runs are unaffected. The legacy test job in
# custard-ci.yaml enforces the same boundary with
# `github.event.pull_request.head.repo.fork == false`.
if: >-
needs.affected.outputs.paths != '[]' &&
(github.event_name != 'workflow_run' ||
github.event.workflow_run.head_repository.full_name == github.repository)
needs: affected
runs-on: ubuntu-latest
timeout-minutes: 120 # 2 hours hard limit
Expand Down
Loading