fix: Build plugin detects changes to SDL .graphql and .gql files marked excluded - #15
Merged
Merged
Conversation
This requires writing a lightweight YAML parser for the schemas, since we can't rely on yams in a build plugin.
This helps to test the manually coded build-plugin yaml parser without introducing complicated fixtures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that #14 doesn't detect changes to
.graphqland.gqlfiles when they have been marked asexcludedin downstream packages, because excluded files aren't present intarget.sourceFiles.With this change, we instead parse
graphql-generator-config.yamland searchtarget.directoryURLdirectly, so we will see excluded files. This also has the side effect of supporting change detection on parent references like../SharedSchemaand avoids regeneration on unrelated.graphqlfiles.