Repository navigation
Honor the Android API requested by Rust build hooks - #122
Open
petralithic wants to merge 2 commits into
Open
petralithic wants to merge 2 commits into
petralithic wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AndroidBuildEnvironmentFactory selects API 35 compiler and linker wrappers regardless of
CodeConfig.android.targetNdkApi. A Flutter application with a lower minimum SDK can therefore bundle a Rust library built for a higher native API.Use the requested API for the C, C++ and Cargo-linker wrappers while retaining both existing API 35 tool-presence checks for the package's NDK compatibility requirement. Missing requested wrappers still raise a validation error. Architecture mappings and other platforms are unchanged.
melos run testpasses on macOS: 29 package tests and one test in each example. The new cases cover ARM64/API 24, ARM32/API 26, a missing requested wrapper, and the existing NDK check. They use temporary compiler stubs; the older-device loader failure reported in #113 has not been tested on a device.Related to #113.