[Feature] 支持 CoreMod 读取 - #6625
Conversation
|
我们需要尽可能多的 coremod 来进行测试 |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 49fce0ba08
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| tree.extractTo(embeddedModFile, tempFile); | ||
| try (ZipFileTree embeddedTree = CompressingUtils.openZipTree(tempFile)) { | ||
| return fromFile(modManager, modFile, embeddedTree, modLoaderType); | ||
| return fromFile(modManager, modFile, embeddedTree, modLoaderType, coreMods); |
There was a problem hiding this comment.
When metadata is obtained through the embedded-mod fallback, coreMods was calculated only from the outer archive and is passed unchanged while the actual mod is read from embeddedTree. Consequently, an embedded mod containing coremods.json, an ITransformationService, or another supported marker is loaded successfully but reported as a non-CoreMod; combine markers detected from embeddedTree with those from the outer archive before constructing the LocalModFile.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
真实性有待确认。主要是没有测试样例，不知道模组加载器这样能不能读取到。我个人倾向于认为不能
4 participants
Closes #6623 Fixes #5555
顺便修复了 1.13.2 Forge REI 元数据加载不出来的问题