Repository navigation
Use exact native permission checks for three AWS privilege routes - #501
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Three AWS privilege routes had generic
requires.all_ofchecks for actions that their native preconditions already verify against the exact request and resources. The generic checks can reject a valid resource-scoped grant before the native evaluator sees it.Change
iam:PassRolecontext.CreateResource, exactiam:PassRole, service trust, and the administrator-user path.The route IDs, preconditions, targets, and outcomes remain unchanged. This PR removes only redundant generic gates and documents where the action checks occur.
Verification