fix(parser): reject non-SBOM input instead of silently passing empty report - #68
Merged
Conversation
…report Closes #21 parse() previously accepted any JSON — a package.json passed by mistake, a truncated export, or garbage — and silently returned an empty CycloneDX SBOM. In a CI gate that read 'nothing changed' (a false negative). - parse() now throws ParseError when input is not a recognized CycloneDX or SPDX document (missing bomFormat/spdxVersion), is invalid JSON, or is not an object (array/null/primitives) - The CLI's loadSbom already wraps this in a clear 'Failed to parse' message; main() exits 1 (verified) - 6 new tests cover the rejection paths + valid-document acceptance 106 tests pass, tsc clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21
Problem
parse() accepted any JSON — a package.json passed by mistake, a truncated export, or garbage — and silently returned an empty CycloneDX SBOM. In a CI gate that read "nothing changed" (a false negative).
Fix
ParseErrorwhen input is not a recognized CycloneDX or SPDX document (missing bomFormat/spdxVersion), is invalid JSON, or is not an object (array/null/primitives)Verification