Skip to content

[ci] Restrict release to manual workflow runs - #1445

Merged
Simn merged 1 commit into
HaxeFoundation:masterfrom
tobil4sk:disable-auto-release
Oct 30, 2026
Merged

Simn merged 1 commit into
HaxeFoundation:masterfrom
tobil4sk:disable-auto-release

Conversation

@tobil4sk

Copy link
Copy Markdown
Member

See: #1432

@Simn

Simn commented Oct 30, 2026

Copy link
Copy Markdown
Member

I don't really understand why this change does what you want it to do but I'm sure you checked that.

What's a "manual workflow run" though?

@Apprentice-Alchemist

Copy link
Copy Markdown
Contributor

https://docs.github.com/en/actions/how-tos/manage-workflow-runs/manually-run-a-workflow

@tobil4sk

Copy link
Copy Markdown
Member Author

workflow_dispatch is an event where you go into the actions tab and manually trigger a workflow. The ui appears once a specific workflow is marked with that trigger on the main branch in the repo. With this change, the release part of the package workflow only occurs when it is run this way (manually).

It might require some testing in a fork before trying to use it for a hxcpp release.

@Simn

Simn commented Oct 30, 2026

Copy link
Copy Markdown
Member

Ideally we'd do this when pushing a tag, but that's another thing we can refine later. I'm happy to go with this for now so we save some work.

on:
push:
branches: [master]
workflow_dispatch:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't it be on top of push?

@Simn
Simn merged commit 0f1615f into HaxeFoundation:master Oct 30, 2026
61 checks passed
@tobil4sk
tobil4sk deleted the disable-auto-release branch October 30, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants