feat(templates): support Container builds in the strands-http-python template - #6
Draft
Hweinstock wants to merge 6 commits into
Draft
feat(templates): support Container builds in the strands-http-python template#6Hweinstock wants to merge 6 commits into
Hweinstock wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
strands-http-pythondidn't support Container builds —create --template strands-python --build Containererrored, and the template shipped noDockerfile.Changes
--template/--buildguard and addresolveRuntimeTemplateShortcut(from fix(scaffold): allow certain template values to be overriden aws/agentcore-cli#2130);--buildetc. can now override a template, only--language/--frameworkstay locked.filteroption toFsTreeNode.fromAssetSource(from feat(templates): wire in memory to the runtime templates aws/agentcore-cli#2116).Dockerfile/.dockerignoreonly whenbuild === "Container".Dockerfile.template+dockerignore.templateto the template. The.templatesuffix (stripped inrenderName, per fix(binary): address missing dockerfile in container agents aws/agentcore-cli#2139) avoidsbun buildembedding an extensionlessDockerfileasDockerfile.— a latent bug that also affectedhello-world-python-container, now fixed.Dockerfile.templatemirrors mainline'scontainer/python/Dockerfile(templated{{entrypoint}}/{{#if enableOtel}}), minus the harness-specific git-skills install block.Verification
Built via
bun run compile:linux-x64;bun test→ 2170 pass.POST /invocationslocally.project deploy) and invoked (aws bedrock-agentcore invoke-agent-runtime) →200, real response.project deploy→CREATE_COMPLETEinus-east-1) and invoked (aws bedrock-agentcore invoke-agent-runtime→200, real response). Note: a region whose CDK bootstrap uses a scoped exec role lackingkms:CreateGrantwill fail ECR-repo creation — an account/bootstrap config matter, not a template/code issue.Reproduce