Skip to content

Configuration errors silently disable integrations #408

Closed

Description

@aram356

Summary

When integration_config() returns an error (typo in TOML, wrong type), .ok() converts it to None, making the integration appear "not configured" rather than "misconfigured". Operators get no feedback that their config is broken.

Refs

  • crates/common/src/integrations/prebid.rs lines 211-212 — .ok().flatten()?
  • crates/common/src/integrations/nextjs/mod.rs lines 97-99 — .ok().flatten()?
  • crates/common/src/integrations/adserver_mock.rs line 373 — BackendConfig::from_url(...).ok()
  • crates/common/src/integrations/aps.rs line 521 — BackendConfig::from_url(...).ok()
  • crates/common/src/integrations/prebid.rs line 950 — BackendConfig::from_url(...).ok()

Recommendation

Log a warning with the error before converting to None, or fail the integration registration with a clear message.

Context

Production readiness audit — see #396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions