Skip to content

Secret store trait (read-only) #485

Closed
Closed

Description

@aram356

Description

Implement PlatformSecretStore read path backed by Fastly SDK. Write stubs return PlatformError::NotImplemented.

Done when

  • Read path wired
  • Write stubs return error
  • Per-PR gates pass

Blocked by

PR 3

References

Activity

  1. self-assigned this
    on Mar 12, 2026
  2. added theissue type on Mar 12, 2026
  3. changed the title [-]EZ PR 4: Secret store trait (read-only)[/-] [+]Secret store trait (read-only)[/+] on Mar 12, 2026
  4. removed their assignment
    on Mar 13, 2026
  5. self-assigned this
    on Mar 25, 2026
  6. prk-Jr commented on Mar 25, 2026

    @prk-Jr
    Collaborator

    The original migration doc scope for this issue included migrating request_signing/signing.rs, jwks.rs, and endpoints.rs off FastlySecretStore to RuntimeServices::secret_store. This was descoped to Approach A (tests only) because that migration requires AuctionContext to carry &RuntimeServices, which is not wired until PR 12.5 (#515), itself blocked by PR 12 (#493).

    What this PR delivers: three tests proving FastlyPlatformSecretStore read path and write stubs satisfy the Done When criteria.

    Deferred to PR 9 (#490): replacing direct FastlySecretStore construction in request_signing/ with trait-based access through RuntimeServices. Acceptance criterion (zero direct FastlySecretStore construction in request_signing/) will be met there, once #515 is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions