You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The original migration doc scope for this issue included migrating request_signing/signing.rs, jwks.rs, and endpoints.rs off FastlySecretStore to RuntimeServices::secret_store. This was descoped to Approach A (tests only) because that migration requires AuctionContext to carry &RuntimeServices, which is not wired until PR 12.5 (#515), itself blocked by PR 12 (#493).
What this PR delivers: three tests proving FastlyPlatformSecretStore read path and write stubs satisfy the Done When criteria.
Deferred to PR 9 (#490): replacing direct FastlySecretStore construction in request_signing/ with trait-based access through RuntimeServices. Acceptance criterion (zero direct FastlySecretStore construction in request_signing/) will be met there, once #515 is available.
Activity
[-]EZ PR 4: Secret store trait (read-only)[/-][+]Secret store trait (read-only)[/+]prk-Jr commentedon Mar 25, 2026
The original migration doc scope for this issue included migrating
request_signing/signing.rs,jwks.rs, andendpoints.rsoffFastlySecretStoretoRuntimeServices::secret_store. This was descoped to Approach A (tests only) because that migration requiresAuctionContextto carry&RuntimeServices, which is not wired until PR 12.5 (#515), itself blocked by PR 12 (#493).What this PR delivers: three tests proving
FastlyPlatformSecretStoreread path and write stubs satisfy the Done When criteria.Deferred to PR 9 (#490): replacing direct
FastlySecretStoreconstruction inrequest_signing/with trait-based access throughRuntimeServices. Acceptance criterion (zero directFastlySecretStoreconstruction inrequest_signing/) will be met there, once #515 is available.