Skip to content

Wire signing to store write primitives #490

Closed

Description

@aram356

Description

Wire request-signing business logic to platform store CRUD primitives via RuntimeServices. Move Fastly management API transport to adapter. Delete api_client.rs from core.

Done when

  • api_client.rs deleted from core
  • management_api.rs in adapter
  • Per-PR gates pass

Blocked by

PR 4

References

Activity

  1. self-assigned this
    on Mar 12, 2026
  2. added theissue type on Mar 12, 2026
  3. changed the title [-]EZ PR 9: Wire signing to store write primitives[/-] [+]Wire signing to store write primitives[/+] on Mar 12, 2026
  4. removed their assignment
    on Mar 13, 2026
  5. prk-Jr commented on Mar 25, 2026

    @prk-Jr
    Collaborator

    In addition to being blocked by PR 4 (#485), this issue now carries the signing.rs migration that was descoped from PR 4.

    Additional scope inherited from PR 4:

    • Replace direct FastlySecretStore construction in request_signing/signing.rs with RuntimeServices::secret_store
    • Same migration for request_signing/jwks.rs and request_signing/endpoints.rs
    • Acceptance criterion: zero direct FastlyConfigStore or FastlySecretStore construction in any request_signing/ module

    Additional blocker: #515 (PR 12.5 — thread RuntimeServices into integration and provider entry points), which is needed before signing.rs can receive &RuntimeServices as a parameter. This is blocked by #493 (PR 12).

  6. self-assigned this
    on Mar 31, 2026
  7. added a commit that references this issue on Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions