Skip to content

Show observed slot size in GPT diagnostics - #1032

Open
ChristianPavilonis wants to merge 1 commit into
mainfrom
fix/gpt-diagnostics-observed-slot-size
Open

Show observed slot size in GPT diagnostics#1032
ChristianPavilonis wants to merge 1 commit into
mainfrom
fix/gpt-diagnostics-observed-slot-size

Conversation

@ChristianPavilonis

Copy link
Copy Markdown
Collaborator

Summary

  • retain GPT-reported slotRenderEnded.size separately from an observed outer slot box
  • measure uniquely bound filled slots after render and update on resize when supported
  • display and export both metrics, with stale-cycle guards and SafeFrame limitations documented

Closes #1031

Validation

  • cd crates/trusted-server-js/lib && npx vitest run (45 files, 834 tests)
  • cd crates/trusted-server-js/lib && npx vitest run test/integrations/gpt_diagnostics/slot_size_observer.test.ts (4 tests)
  • cd crates/trusted-server-js/lib && npm run format
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show observed outer slot size in GPT diagnostics

1 participant