Let a consent prompt run in the phase the publisher chooses

CHANGELOG.md

@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+- A consent management platform's middleware runs in the phase the publisher chooses. `cmp.inmobi`, `cmp.didomi` and `cmp.sourcepoint` may be named in a `[[fetch]]` or a `[[serve]]` entry, where each ran in the fetch phase alone. A generated configuration still places them in `[[fetch]]`. A `[[serve]]` entry naming `cmp.inmobi` for a page whose `[[fetch]]` entry names another middleware is refused, because the serve phase writes its head markup after what the fetch phase writes ahead of the script bundle, so a vendor's tag there would come ahead of the prompt. Naming `cmp.inmobi` for one page in both phases is refused, because the prompt would be written twice.
 - **Breaking:** auction telemetry is selected the way every other module is. `[tinybird]` is now `[analytics.tinybird]`, and `[analytics] module = "tinybird"` selects it, which replaces the `enabled` line. A configuration that still carries `[tinybird]` is refused with directions. A stored configuration written by an earlier version carries the table even where telemetry was off, so push the configuration again with this version. The secret reference is `analytics.tinybird.auction_token_secret`, the table refuses a key it does not know, and a section that selects nothing, or a module this build does not have, is refused. A row is sent only for a reader whose permissions include `analytics.ad_reporting.measure_ad_performance`, so none is sent for a reader the consent gate refuses unless they permit it. The Axum, Cloudflare and Spin adapters send no telemetry, and log a warning at startup when the section selects a module.
 - The DataDome module asks its Protection API about a publisher's pages beneath `/admin/` like any other page. It skipped every path beneath `/admin/` and `/_ts/admin/`, which left a publisher's own `/admin/` pages out of bot protection.
 - **Breaking:** `ts cache purge` asks the hosting platform to purge instead of calling the service. It takes `--service-id <id>` where it took `--service <url>`, reads a Fastly API token from `FASTLY_API_TOKEN` where it read `TRUSTED_SERVER_ADMIN_PASSWORD`, and no longer takes `--username`. It runs `fastly service purge --key`, which needs Fastly CLI 14.0.0 or later, with the surrogate key it derives by the function the service tags its cached objects with, so `--all` and `--page <url>` purge exactly what they purged before.

crates/cmp/didomi/src/lib.rs

@@ -594,7 +594,8 @@ impl DidomiIntegration {
 }
 
 /// Writes the browser module's settings into the head, on the pages a
-/// `[[fetch]]` entry names [`MODULE`] for.
+/// `[[fetch]]` or `[[serve]]` entry names [`MODULE`] for, in the phase the
+/// publisher chooses.
 struct ClientConfig {
     /// The script, made once when the module registers.
     script: String,
@@ -614,7 +615,7 @@ impl Middleware for ClientConfig {
     }
 
     fn phases(&self) -> &[MiddlewarePhase] {
-        &[MiddlewarePhase::Fetch]
+        &MiddlewarePhase::ALL
     }
 
     fn create(&self, _context: &MiddlewareContext<'_>) -> MiddlewareAction {
@@ -1388,6 +1389,16 @@ mod tests {
         assert!(validate_proxy_path("/leading-slash-ok").is_ok());
     }
 
+    #[test]
+    fn the_page_change_may_run_in_either_phase() {
+        let integration = DidomiIntegration::new(Arc::new(config()));
+        assert_eq!(
+            ClientConfig::new(&integration).phases(),
+            MiddlewarePhase::ALL,
+            "the publisher chooses the phase by the entry"
+        );
+    }
+
     #[test]
     fn head_markup_emits_proxy_path() {
         let custom_config = DidomiIntegrationConfig {
@@ -1555,4 +1566,33 @@ mod tests {
             ),
         );
     }
+
+    /// Named in `[[serve]]` in place of `[[fetch]]`, the page change passes
+    /// the registry's check and gives a reader the recorded page, because a
+    /// page with no other middleware gets it in the same place from either
+    /// phase.
+    #[test]
+    fn placed_in_serve_the_page_change_gives_a_reader_the_recorded_page() {
+        use trusted_server_core::html_processor::test_support::{
+            page_settings, place_on_every_page, processed_page,
+        };
+        let mut settings = page_settings(include_str!("fixtures/page-change.settings.toml"));
+        settings.fetch = trusted_server_core::middleware::PhaseEntries::default();
+        place_on_every_page(&mut settings, MiddlewarePhase::Serve, &[MODULE]);
+        let registry = IntegrationRegistry::with_registrations(&settings, &[super::builder()])
+            .expect("the registry should accept the page change in a serve entry");
+
+        let page = processed_page(
+            &settings,
+            &registry,
+            include_str!("fixtures/page-change.input.html"),
+            8192,
+        );
+
+        assert_eq!(
+            page,
+            include_str!("fixtures/page-change.recorded.html"),
+            "a serve entry should give the reader the page a fetch entry does"
+        );
+    }
 }