Repository navigation
chore(conformance): restart the Trust Anchor instead of recreating it - #623
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
run-all.sh recreated conformance-federation-trust-anchor after rewriting its subordinates file, which gives the container a new IP address on the suite network. Nothing has resolved the Trust Anchor by then, so no run is affected today, but a client that had (the suite caches resolved addresses) would keep using the old one. The file is bind-mounted and rewritten in place, so a restart picks it up and keeps the address. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
osanderson
force-pushed
the
chore/ta-restart-not-recreate
branch
from
October 9, 2026 13:26
95f18bb to
f186ea3
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run-all.shnow restartsconformance-federation-trust-anchorafter rewriting its subordinates file, instead of recreating it withdocker compose up -d --force-recreate.Why
Recreating a container gives it a new IP address on the suite network. Anything that had already resolved
conformance-federation-trust-anchorwould keep using the old address: the conformance suite caches resolved addresses. Another project hit exactly this, where containers were recreated between phases.This repo isn't affected today: the recreate runs before the suite or the conformance AS ever contacts the Trust Anchor. Restarting removes the trap should that order ever change.
Why restart is enough
The subordinates file is bind-mounted read-only (
${FEDERATION_TA_SUBORDINATES_FILE}at/subordinates.json), and the script rewrites it in place through the same path. A restart of the same container reads the new content at startup and keeps its address.Verification
bash -n conformance/scripts/run-all.shpasses.chore:, so it adds no release entry.🤖 Generated with Claude Code