Repository navigation
Conversation
GNU libintl on macOS takes the locale from LC_ALL, LC_MESSAGES or LANG before setlocale() and ignores LANGUAGE for "C" and "C.<codeset>", so `setup build` aborted e.g. with LANG=C.UTF-8. With a system locale `NativeGettext` now also sets the environment variable LC_ALL to that locale and restores it like LANGUAGE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #12324, https://mantis.ilias.de/view.php?id=48622
On macOS,
setup buildstill aborted with "Native gettext does not translate: ... in the domain "acc.ar"" if the environment setsLANG=C.UTF-8(reported on Discord) orLC_ALL/LC_MESSAGES/LANGtoC. GNU libintl on macOS takes the locale from these variables beforesetlocale()and ignoresLANGUAGEforCandC.<codeset>.NativeGettextnow also sets the environment variableLC_ALLto that locale and restores it likeLANGUAGE. Linux (glibc) is unchanged.LC_ALLduring the request (documented).Checked on macOS arm64 (Homebrew PHP 8.5, gettext 1.0) with GitHub Actions:
setup buildand lookups pass under 8 locale environments, includingLANG=C.UTF-8, and the Language tests are green. FreeBSD was not affected.