Resolve include loop in ParallelDispatch.h and datatypes.h - #603
Merged
Merged
Conversation
…ompile check as a unit test for this specific include order
aaadelmann
approved these changes
Sep 17, 2026
Collaborator
Author
|
cscs-ci run cscs-ci-mi300 |
Collaborator
Author
|
Tested OPALX-project/OPALX#557 against this branch on Daint: everything (unit and regression tests) worked, even the temporarily deactivated 2.5D unit tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #602
This PR removes
#include "Ippl.h"fromParallelDispatch.hand explicitly adds it todatatypes.h. This breaks the include order explained in the attached issue. The "threadSafe" variable is now queried directly withoutEnv. The rest should be clang-format noise.