Skip to content

[PATCH] Run Tests and CodeQL on release branches - #250

Merged
mtfishman merged 1 commit into
mainfrom
patch/release_branch_workflow_triggers
Sep 9, 2026
Merged

mtfishman merged 1 commit into
mainfrom
patch/release_branch_workflow_triggers

Conversation

@ITensorBot

Copy link
Copy Markdown
Member

Summary

  • Fixes the push.branches entry in Tests.yml, which read release- rather than release-* and so matched no branch, leaving maintenance branches with no post-merge test run.
  • Adds release-* to the pull_request.branches list in CodeQL.yml, which previously ran only on pull requests into main.
  • Both checks are required by the branch ruleset, so they have to run on release branches before that ruleset can cover them.

@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.18%. Comparing base (00e2925) to head (2c895d7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #250   +/-   ##
=======================================
  Coverage   75.18%   75.18%           
=======================================
  Files          29       29           
  Lines        1797     1797           
=======================================
  Hits         1351     1351           
  Misses        446      446           
Flag Coverage Δ
docs 26.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtfishman
mtfishman merged commit 641dac2 into main Sep 9, 2026
11 of 16 checks passed
@mtfishman
mtfishman deleted the patch/release_branch_workflow_triggers branch September 9, 2026 22:16
mtfishman added a commit that referenced this pull request Sep 11, 2026
## Summary

Backports #250, which
landed on `main` after this maintenance branch was cut. A pull request
runs the workflows on the branch it targets, and `CodeQL.yml` here still
triggers only on pull requests into `main`. The ruleset requires that
check on `release-*`, so it never runs and pull requests here stay
blocked.

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants