Avoid allocating a String when hashing a lazy tensor - #252
Merged
Merged
Conversation
Symbol has no method taking a type, so Symbol(typename(T).wrapper) fell back to rendering the type through an IOBuffer on every call. nameof gives the same discriminator as a Symbol for free. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
mtfishman
enabled auto-merge (squash)
September 10, 2026 23:24
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
==========================================
+ Coverage 75.20% 75.33% +0.12%
==========================================
Files 29 29
Lines 1799 1800 +1
==========================================
+ Hits 1353 1356 +3
+ Misses 446 444 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes hashing a lazy tensor allocation-free.
hash_lazybuilt its type discriminator withSymbol(Base.typename(typeof(a)).wrapper), andSymbolhas no method taking a type, so it fell back to rendering the type through anIOBufferon every call.nameofgives the same discriminator as aSymbolfor free.