Migrate to the NamedGraphs v0.14 interface - #174
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
==========================================
+ Coverage 0.00% 80.17% +80.17%
==========================================
Files 13 13
Lines 652 681 +29
==========================================
+ Hits 0 546 +546
+ Misses 652 135 -517
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mtfishman
changed the title
mtfishman
marked this pull request as ready for review
September 9, 2026 02:33
mtfishman
enabled auto-merge (squash)
September 9, 2026 02:33
mtfishman
added a commit
that referenced
this pull request
Sep 9, 2026
## Summary Migrates the 0.9 line to NamedGraphs v0.14, which removed the submodules and the position-graph interface this package imported. The overloads move to the encode and decode interface, and the mutating ones now return `Bool` as Graphs.jl documents. This is #174 ported to `release-0.10`, released as 0.10.0.
NamedGraphs v0.14 removed the submodules and the position-graph interface this package imported, so it no longer loads. The overloads move to the encode and decode interface, and the dead imports go with them, since an import of a removed name fails at load rather than merely being noise.
Graphs.jl documents these as returning whether the operation happened, and DataGraphs now does too, so returning the network or cache left this package inconsistent with its own base class. Also fixes `add_vertex!` on a `MessageCache`, which called `add_edge!` and so could never succeed.
mtfishman
force-pushed
the
mf/namedgraphs-v0.14
branch
from
September 9, 2026 16:06
d9d906e to
be77ae4
Compare
mtfishman
disabled auto-merge
September 9, 2026 16:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NamedGraphs v0.14 removed the submodules and the position-graph interface this package imported, so it no longer loads. The overloads move to the encode and decode interface, and the mutating ones now return
Boolas Graphs.jl documents, which also turned up anadd_vertex!on aMessageCachethat could never succeed.