Skip to content

fix: pyproject.toml: remove pin on gunicorn - #336

Open
vladimir-mencl-eresearch wants to merge 1 commit into
IdentityPython:masterfrom
REANNZ:remove-gunicorn-pin
Open

vladimir-mencl-eresearch wants to merge 1 commit into
IdentityPython:masterfrom
REANNZ:remove-gunicorn-pin

Conversation

@vladimir-mencl-eresearch

Copy link
Copy Markdown
Contributor

The gunicorn package was pinned to 25.0.3 to avoid a deadlock issue introduced in guncorn 25.1.0: benoitc/gunicorn#3529

This has been fixed in benoitc/gunicorn#3520 and the fix was released in guincorn 25.2.0

Remove the explicit pin to last version before the issue (==25.0.3) and instead bump lower bound to the first version fixing the issue.

Run uv sync to update the uv.lock.

All Submissions:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what problem you are trying to solve with this PR?
  • Have you added information on what your changes do and why you chose this as your solution?
  • [N/A] Have you written new tests for your changes?
  • [N/A] Does your submission pass tests?
  • [N/A] This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?

The gunicorn package was pinned to 25.0.3 to avoid a deadlock
issue introduced in guncorn 25.1.0: benoitc/gunicorn#3529

This has been fixed in benoitc/gunicorn#3520 and
the fix was released in guincorn 25.2.0

Remove the explicit pin to last version before the issue (==25.0.3)
and instead bump lower bound to the first version fixing the issue.

Run `uv sync` to update the uv.lock.
@vladimir-mencl-eresearch

Copy link
Copy Markdown
Contributor Author

@theseal , did the tests fail because they try to fetch https://pre.eidas.gov.gr/EidasNode/ConnectorMetadata and that URL was unreachable?

@vladimir-mencl-eresearch

Copy link
Copy Markdown
Contributor Author

@theseal ... and after pre.eidas.gov.gr came back online, rerunning tests just worked.

Would you be OK to merge this? When installing 2.1.7, I saw it downgraded my gunicorn, so I checked why - and when I saw the pin, I looked into the underlying reasons and found the fix in gunicorn was released pretty much right away, so if we avoid the broken version, we should not have to pin.

(And sticking to an old version would stop us from getting any security fixes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant