Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Runs the Ignite UI for Angular 22.3.0
ng updatemigrations on the samples, to test the migrations from IgniteUI/igniteui-angular#17766 (Ignite UI Theming 30.0.0) on a real project.Draft until Ignite UI for Angular 22.3.0 is released (mid-November).
package.jsonstill usesigniteui-angular22.2.0, which uses Ignite UI Theming 29. Theming 29 doesn't accept$generator, so CI fails until the version is updated to 22.3.0.What the migration changed
migration-63adds$generator: 'legacy'to everypalette()function call, so the custom palettes keep the colors they had before. 13 stylesheets changed, in the samples app, app-lob and app-crm. The migration reported nothing for manual review.The three stylesheets that only use the
palettemixin (@include palette(...)) aren't changed, as intended.How it was tested
package.json.migration-63with@angular-devkit/schematics-cli.ng update --migrate-onlyrefuses to run while the installed version differs frompackage.json.ng build --configuration productionformy-app,app-lobandapp-crm. All three pass.vnextwith 22.2.0 for comparison: it has the same warnings and prerender errors. The two theming samples already exceed their budget onvnext, and with Theming 30 they grow by under 1 kB.Before merging
igniteui-angular,igniteui-angular-extrasandigniteui-angular-i18nto 22.3.0 once it's published.Already broken on
vnextgrid-row-editing-styleandhierarchical-grid-row-edit-styleuse$purple-palette, which isn't defined anywhere. This PR doesn't touch them.