Skip to content

refactor(theming): run the 22.3.0 migrations for Ignite UI Theming 30.0.0 - #4062

Draft
simeonoff wants to merge 1 commit into
vnextfrom
simeonoff/update/22.3.0
Draft

simeonoff wants to merge 1 commit into
vnextfrom
simeonoff/update/22.3.0

Conversation

@simeonoff

Copy link
Copy Markdown
Member

Description

Runs the Ignite UI for Angular 22.3.0 ng update migrations on the samples, to test the migrations from IgniteUI/igniteui-angular#17766 (Ignite UI Theming 30.0.0) on a real project.

Draft until Ignite UI for Angular 22.3.0 is released (mid-November). package.json still uses igniteui-angular 22.2.0, which uses Ignite UI Theming 29. Theming 29 doesn't accept $generator, so CI fails until the version is updated to 22.3.0.

What the migration changed

migration-63 adds $generator: 'legacy' to every palette() function call, so the custom palettes keep the colors they had before. 13 stylesheets changed, in the samples app, app-lob and app-crm. The migration reported nothing for manual review.

The three stylesheets that only use the palette mixin (@include palette(...)) aren't changed, as intended.

How it was tested

  1. Built the library, schematics and migrations from the #17766 branch, packed them as 22.3.0, and installed the package without changing package.json.
  2. Ran migration-63 with @angular-devkit/schematics-cli. ng update --migrate-only refuses to run while the installed version differs from package.json.
  3. Ran ng build --configuration production for my-app, app-lob and app-crm. All three pass.
  4. Built vnext with 22.2.0 for comparison: it has the same warnings and prerender errors. The two theming samples already exceed their budget on vnext, and with Theming 30 they grow by under 1 kB.

Before merging

  • Update igniteui-angular, igniteui-angular-extras and igniteui-angular-i18n to 22.3.0 once it's published.
  • Check the themed samples visually.

Already broken on vnext

grid-row-editing-style and hierarchical-grid-row-edit-style use $purple-palette, which isn't defined anywhere. This PR doesn't touch them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant