Repository navigation
fix(nav-toggle): fixing the nav toggle and close directives targets - #17821
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow visibility change preserves runtime behavior, and static review found no blocking issues; tests were not executed.
No open issues 🎉
What changed in this PR
Makes navigation toggle and close targets public so applications can bind them during strict template checking, without changing runtime behavior.
Changes:
- Exposes and documents both directive inputs.
- Adds tests for toggling, closing, and missing targets.
- Documents the fix in the changelog.
| File | Description |
|---|---|
| projects/igniteui-angular/navigation-drawer/src/navigation-drawer/navigation-drawer.component.spec.ts | Adds directive interaction tests. |
| projects/igniteui-angular/core/src/core/navigation/directives.ts | Makes target inputs public and adds API documentation. |
| CHANGELOG.md | Records the template-checking fix. |
Review effort: Balanced
ivanvpetrov
requested changes
Oct 21, 2026
Co-authored-by: ivanvpetrov <110455887+ivanvpetrov@users.noreply.github.com>
…wer/navigation-drawer.component.spec.ts Co-authored-by: ivanvpetrov <110455887+ivanvpetrov@users.noreply.github.com>
ivanvpetrov
self-requested a review
October 21, 2026 14:53
ivanvpetrov
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Both
directives.tsinputs are now public and have JSDoc.igxToggleActionalready declares its input this way.Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)