Repository navigation
Conversation
teodosiah
changed the title
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The localized fix has targeted regression coverage and no identified blocking issues; tests were not executed.
No open issues 🎉
What changed in this PR
Fixes #17693 so populated, non-editing add-row cells use column formatting consistently with existing rows.
Changes:
- Applies formatters and type-specific pipes while preserving empty-cell placeholders.
- Adds regression tests across grid variants, including zero values.
- Configures the add-row sample with a primary key and unique generated IDs.
| File | Description |
|---|---|
| src/app/grid-add-row/grid-add-row.sample.ts | Generates unique IDs for added sample rows. |
| src/app/grid-add-row/grid-add-row.sample.html | Sets the grid primary key. |
| projects/igniteui-angular/grids/tree-grid/src/tree-grid-add-row-ui.spec.ts | Tests add-row date formatting. |
| projects/igniteui-angular/grids/tree-grid/src/tree-cell.component.html | Formats populated tree-grid add-row cells. |
| projects/igniteui-angular/grids/hierarchical-grid/src/hierarchical-grid-add-row.spec.ts | Tests hierarchical-grid add-row date formatting. |
| projects/igniteui-angular/grids/grid/src/grid-add-row.spec.ts | Tests formatting across data types and expandable cells. |
| projects/igniteui-angular/grids/grid/src/expandable-cell.component.html | Formats expandable add-row cells and preserves zero values. |
| projects/igniteui-angular/grids/core/src/cell.component.html | Applies column formatting to standard add-row cells. |
Review effort: Balanced
teodosiah
added
❌ status: awaiting-test
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17693
Description
Motivation / Context
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)