fix(menu): improve framework list visibility and make None exclusive in AI config selections - #1788
Open
ivanvpetrov wants to merge 8 commits into
Open
fix(menu): improve framework list visibility and make None exclusive in AI config selections#1788ivanvpetrov wants to merge 8 commits into
ivanvpetrov wants to merge 8 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
@inquirer/type is referenced in exported types but remains in devDependencies, which can break downstream TypeScript consumers when @igniteui/cli-core is installed as a dependency.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Improves the interactive CLI prompting experience by increasing the visible page size for framework selection in ig new, and introducing an exclusive multi-select prompt so None behaves as a mutually exclusive option in ai-config flows.
Changes:
- Increase framework picker page size to reduce option clipping in
ig new. - Add a custom
exclusiveCheckboxprompt and update AI config prompts to makenoneexclusive. - Add unit tests for the exclusive toggle behavior and add required Inquirer dependency.
File summaries
| File | Description |
|---|---|
| spec/unit/ai-config-spec.ts | Adds unit tests covering None exclusive-toggle behavior. |
| packages/core/prompt/InquirerWrapper.ts | Extends prompt wrapper surface (pageSize + exclusiveCheckbox). |
| packages/core/prompt/ExclusiveCheckbox.ts | Implements a custom exclusive checkbox prompt and exports toggle helper for tests. |
| packages/core/prompt/BasePromptSession.ts | Sets pageSize: 10 for the framework select prompt and extends select options typing. |
| packages/core/package.json | Adds @inquirer/core dependency for the custom prompt implementation. |
| packages/cli/lib/commands/ai-config.ts | Switches AI config selection prompts to the new exclusive checkbox behavior. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the interactive CLI prompt experience in two areas:
ig newshow more items at once to reduce clipping in smaller terminals.Noneact as an exclusive option in AI config multi-select prompts.Changes
Noneimmediately unselects all other options.None.Why
ig new, which hid the last option unless navigating with arrows.Noneshould be mutually exclusive in the UI to match expected meaning, not only normalized after submit.Consideration
Custom implementation for ExclusiveCheckbox introduced, since neither Inquirer nor Enquirer (the main alternative) supports exclusive multi-select behavior out of the box.
How to test:
yarn installnpm run buildnode ...\igniteui-cli\packages\cli\bin\execute.js new