fix: ignore submodules in eslint config - #1793
Open
onlyexeption wants to merge 1 commit into
Open
Conversation
onlyexeption
requested review from
Marina-L-Stoyanova
and
a lite review from Copilot
September 2, 2026 11:14
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a low-risk ESLint ignore-list update that is consistent with existing ignore patterns and has no functional impact beyond reducing unintended lint scope.
Pull request overview
This PR updates the repo’s flat ESLint configuration to ignore documentation-source Git submodules under the MCP server package, preventing ESLint (and typed linting) from traversing and attempting to type-check code that is not part of the monorepo’s TypeScript project configuration.
Changes:
- Adds ignore globs for the
igniteui-doc-mcpdocumentation submodule directories (angular/react/webcomponents/blazor/common). - Documents the rationale inline (submodules are separate repos and not included in this project’s tsconfigs).
File summaries
| File | Description |
|---|---|
| eslint.config.mjs | Extends ignores to exclude MCP doc submodule trees from linting/typed linting. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
coverage: 87.816%. remained the same — ibarakov/fix-eslint-config into master |
Marina-L-Stoyanova
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Closes #
Type of Change
Affected Packages
igniteui-cli(packages/cli)@igniteui/cli-core(packages/core)@igniteui/angular-templates(packages/igx-templates)@igniteui/angular-schematics(packages/ng-schematics)@igniteui/mcp-server(packages/igniteui-mcp)Checklist
npm run test)npm run build)npm run lint)Additional Context