fix(links): update check relative links - #535
Merged
Merged
Conversation
ChronosSF
approved these changes
Sep 8, 2026
ChronosSF
left a comment
Member
There was a problem hiding this comment.
Verified the description against the repo and ran the new script against a fully generated local tree:
- Both content configs root the docs collection at
components, so the/components/...prefix rejection is correct, and the oldresolve(langRoot, path)fallback was indeed what let #530 through. - Astro 7.2.6 strips a trailing
/indexfrom slugs, so the index-page candidates match what publishes. - The toc check mirrors
docExists()insrc/sidebar.ts(as-written plus.md/.mdxswap), and the not-synced-to-Angular filter matchesshouldCopy()insync-generated.mjs. - Against my local tree the PR script reports exactly the two
/components/inputs/button-grouplinks for Angular and the stalegrids/theming-grid.mdxtoc entry for the three xplat platforms, while the base script reported 81 Angular "not found" links that were all xplat-authored topics not yet synced locally. The second content root resolves those as intended. - The jp counterparts need no change: both jp Angular topics already use relative links, and the jp xplat source still has the grid theming page at
grids/theming-grid.mdx, so its toc entry is consistent.
LGTM.
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #530.
Problem
list.mdxandthemes/roundness.mdxlinked Button Group as/components/inputs/button-group, which 404s andcheck-relative-linkspassed.The docs collection is rooted at
content/<lang>/components(
docs/*/src/content.config.ts), socomponents/is never a URL segment.#468 moved the topic into xplat, which legitimately changed its URL from
/button-groupto/inputs/button-group, but the links were rewritten with thenew file path rather than the new URL. (The same commit updated
toc.jsoncorrectly, because toc hrefs really are file paths.)
The check couldn't catch it:
resolveAbsoluteLinkcarried a fallback candidate,resolve(langRoot, path), encoding that same wrong model. The bad link matched areal file on disk, so CI went green. That fallback had been there since the
checker landed in #355.
Content
/inputs/button-group.Grid → Themingentry pointed at a page that doesn'texist in EN and was being silently dropped from the sidebar on all three xplat
sites.