Skip to content

feat(chip): update chip xplat topic - #903

Merged
ChronosSF merged 11 commits into
vnextfrom
iminchev/update-chip-topic
Oct 23, 2026
Merged

ChronosSF merged 11 commits into
vnextfrom
iminchev/update-chip-topic

Conversation

@IMinchev64

@IMinchev64 IMinchev64 commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Closes #701

React samples: IgniteUI/igniteui-react-examples#1118
WC samples: IgniteUI/igniteui-wc-examples#1294
Blazor samples: IgniteUI/igniteui-blazor-examples#1321
Angular samples: IgniteUI/igniteui-angular-samples#4050

Checklist:

  • check topic's TOC/menu and paragraph headings
  • Include TOC topic labels in the topic content when it has a valuable update, is new, or is considered preview / beta
  • link to other topics using ./page.mdx or ../relative/path.mdx (.mdx extension required)
  • at the References section at the end of the topic add links to topics, samples, etc
  • reference API documentation instead of adding a section with API

  • use valid component names - [Data] Grid, IgxSelectComponent, <igx-combo>
  • use spell checker tool (VS Code, Grammarly, Microsoft Editor)
  • add inline code blocks for the names of classes / tags / properties
  • add language descriptor for the code blocks
  • check if links function by running the check-api/mdx npm commands
  • check if sample is working and fully visible in the topic
  • check if sample is working and fully visible in the StackBlitz
  • check if code blocks match the code in StackBlitz demo
  • add or update meaningful llms.description metadata and run npm run check:llms-metadata


  • do not resolve requested changes (leave that to the reviewer)

IMinchev64 and others added 2 commits October 7, 2026 17:30
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@IMinchev64 IMinchev64 added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. ❌ status: awaiting-test PRs awaiting manual verification and removed status: awaiting-sample topic is missing a sample ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. labels Oct 8, 2026
@DiLazarova

Copy link
Copy Markdown
Contributor

Test and Review for Chip - React / Chrome

1. Live Demo

Please use the Live Demo design from Figma File : Figma Design

Screenshot 2026-10-12 at 14 17 15

2. Layout

Please, use for Indigo theme the Indigo Arrow Icon - indigo-arrow-upward. This is relevant for ALL EXAMPLES with indigo theme for both light and dark mode.
Screenshot 2026-10-12 at 16 06 44

3. Outlined Chip

Please use the outline variants for this example
Screenshot 2026-10-12 at 16 14 18

4. Size

Please double check the Chip background color for Material theme - Light Mode. Should be #E0E0E0
Screenshot 2026-10-12 at 16 32 53

5. Section "Remove Chip" to be "Read only" with no interactions

No need for "restore chip" button
Screenshot 2026-10-12 at 17 35 15

Screenshot 2026-10-12 at 17 35 23

Comment thread docs/xplat/src/content/en/components/inputs/chip.mdx Outdated
Comment thread docs/xplat/src/content/en/components/inputs/chip.mdx Outdated
Comment thread docs/xplat/src/content/en/components/inputs/chip.mdx Outdated
Comment thread docs/xplat/src/content/en/components/inputs/chip.mdx Outdated
Comment thread docs/xplat/src/content/en/components/inputs/chip.mdx Outdated
Comment thread docs/xplat/src/content/en/components/inputs/chip.mdx
@Hristo313 Hristo313 added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Oct 19, 2026
Hristo313
Hristo313 previously approved these changes Oct 21, 2026
@Hristo313 Hristo313 added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Oct 21, 2026
@ChronosSF
ChronosSF self-requested a review October 21, 2026 16:13

@ChronosSF ChronosSF left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sample-related but writing it here because it spans all platforms.

Can we have the remove button on the Remove Chip section actually do something. I clicked on it and was surprised it doesn't do anything. I know removing a chip is an application scenario but it doesn't mean we can't implement it for this sample.

Have it remove the chip and add a button in its place that lets you restore it or something simple liek that. You can also just restore it after 3 seconds with a toast counting down or something like that, doesn't have to be super complicated.

@ChronosSF
ChronosSF self-requested a review October 23, 2026 06:02
@ChronosSF
ChronosSF merged commit 697e3b5 into vnext Oct 23, 2026
16 checks passed
@ChronosSF
ChronosSF deleted the iminchev/update-chip-topic branch October 23, 2026 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chip doc-redesign status: ✔️ by-design ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

inputs/chip.mdx

4 participants