Skip to content

feat(grids): add theming article in xplat - #929

Merged
simeonoff merged 12 commits into
vnextfrom
apetrov/add-grid-theming
Oct 23, 2026
Merged

simeonoff merged 12 commits into
vnextfrom
apetrov/add-grid-theming

Conversation

@adrianptrv

@adrianptrv adrianptrv commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Closes #897

The article is available in React, Web Components, and Blazor.
Should be merged together with the following samples:
IgniteUI/igniteui-wc-examples#1298
IgniteUI/igniteui-react-examples#1121
IgniteUI/igniteui-blazor-examples#1326

@adrianptrv
adrianptrv requested a review from simeonoff October 9, 2026 11:59
@adrianptrv adrianptrv added grid area: enhancement New feature or request labels Oct 9, 2026

@simeonoff simeonoff left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrianptrv The content is accurate, but the page leads with what doesn't work ("Explicitly set properties"). Until derived tokens ship by default, I'd like the topic to steer people toward generating themes. Suggestions:

Structure

  1. Intro → example → Create a theme → Apply it → Primary tokens → How derivation works → Going deeper → Structure → Fine-tune individual properties → Try it.
  2. Intro: promise the 3-color theme with its condition stated, e.g. "Build a theme from a background, foreground and accent color and every other color is derived from them. You don't write the derived colors yourself; generate them with grid-theme(), the Theming MCP or the playground."

Create a theme (new section, replaces the Sass section and the "snapshot" warning)

  • Sass: grid-theme(). Add the npm i igniteui-theming step, which is currently missing.
  • Theming MCP: link ai/theming-mcp.mdx with a sample prompt (CSS output, no Sass toolchain). This should be the recommended route for Blazor.
  • Playground: link to the one at the bottom.
  • State "regenerate when you upgrade" as a normal workflow step rather than a warning.

Fine-tune individual properties (move "Explicitly set properties" here and reframe it)

  • Present independent properties as a feature: a single override changes only that part.
  • Then say that --ig-grid-background / --ig-grid-accent-color alone won't carry into the rest of the grid, and link back to Create a theme.

Other

  • Don't say "three tokens restyle the whole grid" without the "in a generated theme" condition.
  • grids/grid/theming-grid.mdx (old, unprefixed vars) is still linked from about 10 shared topics. Redirect it to this page or retire it.
  • Frontmatter lacks the mentionedTypes and namespace fields that sibling shared topics have. The JP toc isn't updated.

adrianptrv and others added 4 commits October 23, 2026 11:29
… old topic

- State that igniteui-theming must be upgraded on its own
- Scope the gray-100 header fallback example to the Material theme
- Restore the grid-theme() API link for Web Components and React
- Remove the EN theming-grid topic and redirect it to the new theming
  topic (JP keeps its page until the new topic is translated)
@simeonoff
simeonoff merged commit 32b4692 into vnext Oct 23, 2026
16 checks passed
@simeonoff
simeonoff deleted the apetrov/add-grid-theming branch October 23, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: enhancement New feature or request grid

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Grid Theming: Documentation and Supporting Samples

2 participants