Repository navigation
Conversation
…and 'size' samples (#1116)
fix(samples): update samples styling
Weekly grouped version updates for GitHub Actions with a 14-day cooldown, identical to igniteui-blazor's .github/dependabot.yml. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Bumps the github-actions group with 2 updates: [actions/checkout](https://github.com/actions/checkout) and [actions/github-script](https://github.com/actions/github-script). Updates `actions/checkout` from 6 to 7 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v6...v7) Updates `actions/github-script` from 8 to 9 - [Release notes](https://github.com/actions/github-script/releases) - [Commits](actions/github-script@v8...v9) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: actions/github-script dependency-version: '9' dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Type-check samples in CI Samples are outside `astro check`, and their own tsconfigs mostly use `moduleResolution: node`, which cannot see the types the IG packages publish through `exports`. Every IG component types as `any`, so a prop the component does not have passes unnoticed; vnext merged two color-picker samples that way. `npm run check:samples` checks every published sample in one program with tsconfig.samples.json: the add:sample settings, bundler resolution, not strict. It takes about 30 seconds. A shim restores the global JSX.Element that @types/react 19 removed, which 683 generated samples still use. 25 samples fail today. They are listed with the reason in scripts/lib/known-type-errors.json, so CI blocks only new errors. A listed sample that no longer fails also fails the check, so the list only shrinks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Fail on every sample type error Drop the known-failures list: the check now fails on any type error in a published sample, so CI stays red until the 25 samples it listed are fixed. Samples in unpublished.json are still skipped, as everywhere else. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Run the build and smoke tests when a check fails A failed step skips every later one, so the red sample type check hid whether the build and smoke tests pass. The build now runs regardless, and the smoke tests whenever the build succeeds. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Fix type errors in hand-maintained samples The errors `npm run check:samples` found in the 20 samples maintained here, not exported from igniteui-xplat-examples: - x-date-picker date-limits, editing, format: create `root` before root.render(), as the other x-date-picker samples do. They threw when run on their own; the browser strips the mount, so its build is byte-identical. - grid editing-excel-style, date-range-picker slots: give useRef() an initial value, which React 19 requires. - grid localization: type the IgrSelect change handler as the CustomEvent it is, reading the value from the selected item. - grid-lite sort-config-events, sort-config-pipeline: readOnly, not the attribute name readonly. The ratings were read-only already. - grid-lite styling-config-themes: declare its igc-* tags in React.JSX, which React 19 reads instead of the global JSX namespace. - badge dot, icon, overview, tailwind-styling, type; color-picker tailwind-styling: drop size, removed from every component in igniteui-webcomponents 5.0. The badge CSS already sets --ig-size. - color-picker styling: drop placeholder, which it does not have. - button-group custom-toggle: selection="multiple", not selectionMode="multi". The buttons were single-select; they now multi-select, as in the Web Components sample. - chat features: pass createChatMarkdownRenderer() its options object; every option is optional. Screenshots of the 15 samples that render deterministically are pixel-identical before and after. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Skip generated samples with type errors in the check Five samples exported from igniteui-xplat-examples fail the check; a fix made here is lost at the next export. scripts/lib/skip-type-check.json lists them with their errors until the fix lands there. They stay published: unpublished.json would also drop them from the site and the docs code viewer. Turn off noUncheckedSideEffectImports, as in the TypeScript 5.9 the samples build with: igniteui-react-grids/grids/combined is an untyped side-effect entry, not an error in the two samples that import it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Add AGENTS.md and a CLAUDE.md that imports it AGENTS.md tells coding agents what the code alone does not: which samples igniteui-xplat-examples generates and how to tell, the sample contract the Astro build depends on, the checks CI runs, and the deploy and docs contract that URLs and code-viewer JSON must keep. Claude Code reads AGENTS.md only in newer versions and only when no CLAUDE.md or CLAUDE.local.md exists, so CLAUDE.md imports it with @AGENTS.md and every agent gets the same instructions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Describe the strict sample type check in AGENTS.md Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Describe the type-check skip list in AGENTS.md Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.