Skip to content

feat(rating): update samples content - #1119

Merged
ChronosSF merged 6 commits into
vnextfrom
hhristov/update-rating-samples
Oct 23, 2026
Merged

ChronosSF merged 6 commits into
vnextfrom
hhristov/update-rating-samples

Conversation

@Hristo313

@Hristo313 Hristo313 commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Update Rating samples

@IMinchev64 IMinchev64 added status: verified The PR is tested and ready for a merge and removed awaiting-test labels Oct 22, 2026
ChronosSF and others added 2 commits October 23, 2026 09:59
Bring in the Astro migration (#1110), the sample type check (#1132),
AGENTS.md (#1133) and everything else merged to vnext since.

Conflicts:
- rating basic, custom, empty and single-selection: removed here,
  converted on vnext. Kept removed.
- browser/public/meta.json, browser/src/navigation/SamplesBrowser.json:
  regenerated here; vnext removed browser/. Kept removed.
- rating styling: this branch had already rewritten it as a function
  component with new content, so its side is kept, in vnext's style:
  no JSX.Element return type, which React 19's types no longer declare,
  no unused React import, and the `getElementById('root')!` mount.

The six new rating samples (interaction-states, layout, overview, size,
states, tailwind-styling) get what vnext did to every sample: no
.eslintrc.js, sandbox.config.json or .devcontainer/, README.md in the
current format without the CodeSandbox link, the strict add:sample
tsconfig, and package versions from scripts/lib/versions.js.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The font @import came after the Tailwind imports. Tailwind's output
then places it after style rules, where browsers ignore it, so the
sample lost its font when run standalone and in the StackBlitz project
the docs open. The samples browser hoisted it, which hid this.

Put it between the @layer statement and the Tailwind imports, the order
chip/tailwind-styling uses, which works in both pipelines.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ChronosSF
ChronosSF merged commit af8f82e into vnext Oct 23, 2026
5 checks passed
@ChronosSF
ChronosSF deleted the hhristov/update-rating-samples branch October 23, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: verified The PR is tested and ready for a merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants