Skip to content

docs: add configuration guide (wiki + docs/CONFIGURATION.md) - #401

Open
igoroctaviano wants to merge 2 commits into
masterfrom
docs/207-wiki-configuration
Open

docs: add configuration guide (wiki + docs/CONFIGURATION.md)#401
igoroctaviano wants to merge 2 commits into
masterfrom
docs/207-wiki-configuration

Conversation

@igoroctaviano

Copy link
Copy Markdown
Collaborator

Summary

Topics documented

  • External DICOMweb server configuration
  • Runtime server selection via enableServerSelection (header API / “link” icon)
  • Secondary GCP annotation store via the gcp query parameter
  • Per-finding annotation colors (annotations[].style) and note on selection highlight
  • Read-only mode (disableAnnotationTools) and disabling the worklist (disableWorklist)
  • Local Orthanc / CORS troubleshooting (addresses the setup confusion raised in Create documentation page in the wiki #207)

Related issues

Test plan

  • Review docs/CONFIGURATION.md for accuracy against src/AppConfig.d.ts and public/config/*.js
  • Confirm README links resolve
  • Confirm wiki Configuration page matches the repo doc after wiki push
  • Spot-check that enableServerSelection: true still shows the header server button as described

Document external servers, runtime server selection, the gcp secondary
source, annotation colors, and read-only/worklist flags so #207 and #5
have a single reviewable page in-repo and on the wiki.
@deepsource-io

deepsource-io Bot commented Jul 29, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 7751f2b...5da4028 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript Jul 29, 2026 8:59p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 5da4028):

https://idc-external-006--pr401-docs-207-wiki-config-n7gjedwm.web.app

(expires Wed, 05 Aug 2026 21:01:50 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 88aacecd98ba54d2f9c8d201a9444e43d1ad8307

Fix inaccurate claims about gcpBaseUrl, runtime custom-server write
mode, annotation/ANN style models, selection colors, and secondary gcp
bulkdata client behavior found in a full codebase review.
@igoroctaviano

Copy link
Copy Markdown
Collaborator Author

Follow-up commit after reviewing the guide against Slim and dicom-microscopy-viewer (0.48.22):

Corrections

  • gcpBaseUrl does not affect path-only server selection or ?gcp= (only GCP path-based default-server rewrite)
  • Custom runtime server is write: false and collapses SOP-class client mapping (including ?gcp= split) until default is restored
  • Documented slim_server_selection_mode persistence
  • Split SR ROI vs bulk ANN style models (dmv setROIStyle vs setAnnotationGroupStyle)
  • Clarified yellow default vs palette fallback, selection vs dmv ANN highlight colors
  • Noted dmv ANN bulkdata fetch via SM client when using secondary gcp
  • disableAnnotationTools also hides bundled toolbar controls (e.g. Go to); disableWorklist does not remove deep-link routes

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create documentation page in the wiki Configurable servers

1 participant