fix: align device list with InfiniRT master#792
Closed
voltjia wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kKunlunandkQydevice references from active device lists, PyTorch backend instantiations, wrapper codegen, and docs examples.Motivation
Current InfiniOps master fails to build against current InfiniRT master because InfiniOps still references
Device::Type::kKunlunandDevice::Type::kQy, which are no longer exported by InfiniRT master. This blocks NVIDIA smoke builds withWITH_TORCH=ON, including the reduced PyTorch backend operator set.Closes #
Type of Change
feat- new feature / new operator / new platformfix- bug fixperf- performance improvement (no behavioral change)refactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Test Results on Supported Platforms
accelerator-dev/nvidia:latest.Full `pytest` output (optional)
Benchmark / Performance Impact
N/A - build compatibility fix only.
Notes for Reviewers
This PR intentionally follows the device enum currently exported by InfiniRT master. It does not add replacement support for removed
kunlunorqydevice names.