fix: refresh netmap error - #38
Merged
Merged
Conversation
Signed-off-by: kerthcet <kerthcet@gmail.com>
InftyAI-Agent
added
needs-triage
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates SandD’s Tailscale tunnel handling to reduce noisy logs from tailscaled and to recover faster when the daemon can’t reach a restarted controller due to stale netmap state.
Changes:
- Pass the server
verboseflag into the controller tunnel setup and optionally mutetailscaledoutput. - Add
stale_netmaptracking in the daemon reconnect loop to force atailscale down/uprefresh after unreachable-controller failures. - Replace
tailscale status-based “is tailscaled running” detection with a SOCKS5-port readiness probe and an active wait-for-ready loop.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| server/src/lib.rs | Threads the verbose flag into controller tunnel setup and attempts to reduce tailscaled log noise. |
| sandd/src/main.rs | Adds stale-netmap refresh logic and improves tunnel readiness detection/behavior in the reconnect loop. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: kerthcet <kerthcet@gmail.com>
Signed-off-by: kerthcet <kerthcet@gmail.com>
Member
Author
|
/lgtm |
InftyAI-Agent
added
lgtm
Signed-off-by: kerthcet <kerthcet@gmail.com>
InftyAI-Agent
removed
the
lgtm
Member
Author
|
/lgtm |
InftyAI-Agent
added
the
lgtm
InftyAI-Agent
approved these changes
Aug 4, 2026
InftyAI-Agent
left a comment
InftyAI-Agent
left a comment
Member
There was a problem hiding this comment.
Approved: PR has both lgtm and approved labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer
Does this PR introduce a user-facing change?