Replace Modified() call in itk::Object, remove Modified() call from BSplineDeformableTransform

[N-Dekker]

• Removed the Modified() call from the default-constructor of BSplineDeformableTransform, as follow-up to pull request STYLE: Remove SetFixedParameters... functions from BSplineBaseTransform #6854
• Replace the Modified() call with m_MTime.Modified() in the default-constructor of itk::Object. For an Object that is still "under construction", it appears overdone to call this->Modified(), because it does not yet have any observer to listen to its ModifiedEvent. Moreover, it appears preferable to avoid calling virtual functions within a constructor: C++ Core Guidelines, Don’t call virtual functions in constructors and destructors.

---

For the record Object::Modified() is defined here:

ITK/Modules/Core/Common/src/itkObject.cxx

Lines 345 to 353 in fd3b0b4

	/**
	* Make sure this object's modified time is greater than all others.
	*/
	void
	Object::Modified() const
	{
	m_MTime.Modified();
	InvokeEvent(ModifiedEvent());
	}

It appears to have overrides at:

Modules/Core/ImageAdaptors/include/itkImageAdaptor.h
Modules/Filtering/ImageIntensity/include/itkNormalizeImageFilter.h
Modules/Filtering/MathematicalMorphology/include/itkGrayscaleDilateImageFilter.h
Modules/Filtering/MathematicalMorphology/include/itkGrayscaleErodeImageFilter.h
Modules/Filtering/MathematicalMorphology/include/itkGrayscaleMorphologicalClosingImageFilter.h
Modules/Filtering/MathematicalMorphology/include/itkGrayscaleMorphologicalOpeningImageFilter.h
Modules/Filtering/MathematicalMorphology/include/itkMorphologicalGradientImageFilter.h
Modules/Filtering/ParabolicMorphology/include/itkBinaryDilateParabolicImageFilter.h
Modules/Filtering/ParabolicMorphology/include/itkBinaryErodeParabolicImageFilter.h
Modules/Filtering/ParabolicMorphology/include/itkMorphologicalDistanceTransformImageFilter.h
Modules/Filtering/ParabolicMorphology/include/itkParabolicOpenCloseSafeBorderImageFilter.h
Modules/Nonunit/Review/include/itkMiniPipelineSeparableImageFilter.h

[dzenanz]

Change is small, and reasoning makes sense. CI can totally sink it, though 😄

[greptile-apps]

Greptile Summary

Summary

• Initializes object modification timestamps directly during construction and removes a redundant B-spline construction-time modification call.
• No actionable issues were identified.

T-Rex validation blocked

• Runtime compilation could not run because the CMake-generated itkConfigure.h header and the CMake/Ninja toolchain are unavailable.

Confidence Score: 5/5

No blocking issues were identified; the change is safe to merge.

The review identified no actionable findings. The attempted before-and-after construction check was blocked equally in both revisions by missing generated build configuration.

Files Needing Attention: No files require changes. Runtime construction behavior can be rechecked once a configured ITK build environment is available.

T-Rex Logs

What T-Rex did

• I compared construction-time modifications between the pre-change and updated revisions and ran the narrow itkObject.cxx compilation check.
• I observed that both checks halted at the same missing itkConfigure.h header, so runtime construction behavior could not be observed.
• I authored and executed the pr6855-construction-check.sh script, capturing before, after, and runner outputs.
• I documented that the construction-check run produced no actionable findings.

_{Ran code and verified through T-Rex}

_{Reviews (1): Last reviewed commit: "STYLE: Replace Modified() with m_MTime.M..." | Re-trigger Greptile}