Skip to content

Use SpacePrecisionType for direction data in DICOMOrient GTest - #36

Merged
blowekamp merged 2 commits into
mainfrom
comp-float-space-precision
Nov 9, 2026
Merged

blowekamp merged 2 commits into
mainfrom
comp-float-space-precision

Conversation

@dzenanz

@dzenanz dzenanz commented Nov 6, 2026

Copy link
Copy Markdown
Member

Addressing build error raised on the dashboard.

@dzenanz
dzenanz requested a review from blowekamp November 6, 2026 13:51
The clang-format linter action checks only files with the
hooks.style=clangformat attribute, and fails when none have it.
vnl_matrix_fixed<float> cannot be initialized from a double array
when ITK_USE_FLOAT_SPACE_PRECISION is ON.
@dzenanz
dzenanz force-pushed the comp-float-space-precision branch from c64de17 to 293a7c4 Compare November 6, 2026 19:15
@dzenanz

dzenanz commented Nov 9, 2026

Copy link
Copy Markdown
Member Author

@blowekamp review/merge?

@blowekamp blowekamp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing the warning.

@blowekamp
blowekamp merged commit 488a7bb into main Nov 9, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants