parser: remove dead raw_parser NULL guard - #1884
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthrough
ChangesParser hook behavior
Estimated code review effort: 2 (Simple) | ~5 minutes Merge Risk: ⚪ Minimal · up to The change removes an unreachable parser-hook guard and directly invokes the initialized parser hook. No concrete merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This PR removes the unreachable NULL guard in
raw_parser().sql_raw_parseris initialized to a valid parser and is not reset in normal flow, so the branch cannot be hit. Keeping only the direct call makes the code simpler and avoids a misleading error path.No functional tests were run; this is a code-quality cleanup only.
Summary by CodeRabbit