redgate: point hooks at the handlers that exist; sort runs in C locale

[JRichlen]

Two fixes lifted out of #115 so they do not wait on 76k lines. Three changed lines, plus a cheap-tier section that would have caught the first one.

The shipped defect

plugins/redgate/hooks/hooks.json referenced ${CLAUDE_PLUGIN_ROOT}/hooks-handlers/<handler>.sh. Both handlers live under hooks/hooks-handlers/, and ${CLAUDE_PLUGIN_ROOT} is the plugin directory on an installed plugin — agent-compiler's own hooks.json resolves the same way. There is no plugins/redgate/hooks-handlers/ directory.

So on every installed copy of redgate, the PreToolUse write guard — the hook that stops a write reaching a ratified run's contract while its round is in MIDDLE — and the SessionStart announcer silently never ran. The cheap tier stayed green throughout, because nothing resolved handler paths against the filesystem.

-  "command": "bash \"${CLAUDE_PLUGIN_ROOT}/hooks-handlers/guard-redgate-paths.sh\""
+  "command": "bash \"${CLAUDE_PLUGIN_ROOT}/hooks/hooks-handlers/guard-redgate-paths.sh\""
-  "command": "bash \"${CLAUDE_PLUGIN_ROOT}/hooks-handlers/session-start.sh\""
+  "command": "bash \"${CLAUDE_PLUGIN_ROOT}/hooks/hooks-handlers/session-start.sh\""

The locale sort

criteria-index.sh sorted run directories with the host locale. Its own header promises deterministic output and --check compares against it, so an en_US host can order slugs differently from CI and report drift that is not there.

-  for run in $(ls -d "$RG"/*/ 2>/dev/null | sort); do
+  for run in $(ls -d "$RG"/*/ 2>/dev/null | LC_ALL=C sort); do

The guard

New cheap-tier section 2b resolves every ${CLAUDE_PLUGIN_ROOT}/<rel> in every plugins/*/hooks/hooks.json to a file under plugins/<p>/<rel>, one PASS/FAIL per handler, and fails closed if the walk finds nothing. It is resolved against the filesystem rather than pattern-matched on purpose: voice's hooks.json uses the identical-looking hooks-handlers/ path and is correct, because voice keeps its handler directly under the plugin root. A pattern rule would have flagged the healthy plugin and could not have told the two apart.

Verification

Check	Result
cheap tier, this branch	1295 passed, 0 failed (1290 on main + 5 handler paths)
section 2b against main's pre-fix hooks.json	both redgate hooks reported missing — 1293 / 2 failed
mutation: agent-compiler handler renamed away	red (1294 / 1)
mutation: walk pointed at an empty glob	red — "resolved ZERO handler paths" (1290 / 1)
all five current handler paths	resolve: agent-compiler ×2, redgate ×2, voice ×1

Not verified here, stated rather than implied:

• The locale ordering difference. No en_US locale is installed in this container; LC_ALL=en_US.UTF-8 falls back to C and sorts identically. The one-line fix rests on sort(1) semantics and feat(evals): marketplace-wide agentic test framework (T01–T52) with red-team lane #115's report of a red cheap tier on en_US hosts, not on a reproduction.
• The deep tier. Its path filter matches criteria-index.sh (plugins/*/skills/**/scripts/**), but redgate ships no pier pack, so deep tier (pier) will report green because its leg is skipped, not because anything ran. That is the existing gate design, named here so a green is not read as proof.

No SKILL.md, command, or skill references/ touched, so demonstration discipline does not apply. No eval tier, workflow job, or eval pack added, removed, renamed, or re-scoped, so docs/testing.md is unchanged and section 20 stays green.

Independent of the OpenRouter credit outage blocking #131 and #133 — nothing here calls a model.

🤖 Generated with Claude Code

https://claude.ai/code/session_01XHYtoYrtWhTGy59GC9uJGd

---

Generated by Claude Code

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-15T02:20:52.997686Z	a9145b8	PR opened
🔒 Security Review	✅ Completed 2026-09-15T02:32:38.805357Z	a9145b8	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[Copilot]

🟡 Changes recommended

The handler-path validation needs canonical containment checks and reliable walker error propagation.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

This PR fixes Redgate hook paths, makes criteria indexing locale-independent, and adds cheap-tier handler validation.

Changes:

• Corrects both Redgate hook handler paths.
• Forces criteria sorting with LC_ALL=C.
• Adds filesystem-based hook path checks.

File summaries

File	Summary
plugins/redgate/skills/criteria-contract/scripts/criteria-index.sh	Makes run ordering deterministic across locales.
plugins/redgate/hooks/hooks.json	Corrects handler locations.
evals/cheap/run.sh	Validates resolved hook handler paths.

Review details

Suppressed comments (1)

evals/cheap/run.sh:82

• The Python walker runs in process substitution, so its non-zero exit status is not propagated by set -o pipefail and the loop only checks whether it saw any output. If an earlier plugin emits valid paths and a later syntactically valid but structurally malformed hooks.json raises inside this walker, hook_paths_seen remains nonzero and section 2b reports no failure instead of failing closed. Capture and check the walker's exit status (or run it as a normal command) before accepting the results.

)

• Files reviewed: 3/3 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a9145b8edd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[JRichlen]

Pushed 2af3101. Two corrections to section 2b, one of them mine to own.

Counterfeit tier was red, and it was this PR's fault. The corpus's synthetic marketplace ships no hooks.json at all, and the section's "zero paths resolved" fail-closed turned that root red — the corpus's own calibration guard said "baseline plugin is NOT green — corpus is miscalibrated, every rejection below is meaningless". Reproduced locally at 24 / 1 before touching anything. The section now counts hooks.json files separately from extracted paths: no files is a legitimate "nothing to check" (the same PASS shape every other section uses for an absent surface); files present but zero paths extracted still fails closed, because that is the walk breaking, not the plugins being clean. Counterfeit harness now 25 / 0, baseline green, all 18 counterfeits rejected by their expected gate.

Copilot's containment finding was correct and is fixed — both paths are realpath'd and the target must share the plugin dir as its commonpath, the same idiom the link resolver further down already uses. The ../ case is now a mutation in the verification set: pointed at a real file in redgate from agent-compiler's hooks.json, isfile alone says OK and the section correctly fails.

Five mutations against the final section, cheap tier 1295 / 0 unchanged. One null result recorded honestly: the regex-break mutation's first attempt didn't apply (a sed pattern missed the heredoc's escaping and left the file untouched at 1295 / 0) — that was no evidence at all, so it was redone with an applied edit, which fires "3 file(s) present but the walk extracted ZERO handler paths".

Two things this run revealed that are outside this diff:

• The behavioral tier — promptfoo (redgate) leg ran for real (by design — plugins/<p>/hooks/** is behavior surface) and passed 9 / 9 with 0 errors on the live subject. That is the first paid-tier evidence in six days that the OpenRouter account is funded again; evals: confirm the SUBJECT model resolves, and repin it to qwen/qwen3.8-flash #131 and Portal/shunt delegation research, and three skills it sharpens #133 are no longer blocked on credit.
• That same leg logs evals/paid/capture-example.sh: Permission denied — the script isn't executable, so the gallery capture step is a silent no-op in CI (guarded by || true; the 4 KB "snapshot" artifact is the checked-in docs/examples/data/redgate.json, not a fresh capture). Pre-existing on main, untouched here; noting it rather than widening this PR.

---

Generated by Claude Code