Skip to content

fix(web): Open-source licenses shows no server picker - #712

Merged
Jacksondr5 merged 1 commit into
j5/mainfrom
j5code/licenses-no-server-picker
Oct 25, 2026
Merged

Jacksondr5 merged 1 commit into
j5/mainfrom
j5code/licenses-no-server-picker

Conversation

@Jacksondr5

@Jacksondr5 Jacksondr5 commented Oct 25, 2026 •

Copy link
Copy Markdown
Owner

Problem

Settings › Open-source licenses showed the Settings server picker ("Applying settings for …"). The page is the same for every server, so the picker did nothing there. Since #638 a non-Owner sees this page too, so more people saw the picker. Closes #646.

What changed

The licenses path joins SETTINGS_DEVICE_ONLY_PATHS, the list of pages that show no scope picker, beside Appearance, SnapShots, Connections and People. For a non-Owner, the same list also lets the page through upstream's scope boundary, so the licenses show even when the person owns no server whose scope could be resolved.

UI changes

Owner, Settings › Open-source licenses

Before After
"Applying settings for All projects across All environments" above the licenses. No picker.

A Viewer at project scope, the same page

Before After
The picker above the list. No picker; the licenses list still shows.

Owner, Settings › General, after: other pages keep the picker.

Live testing

Pass. A tester agent (Claude Sonnet 5.5) ran head aaf0e05a11 against base 90e159d0e7 with the live-test rig's --base setup, so both showed the same data. Checked: the Owner and a project-scope Viewer on the licenses page, and the Owner on General. The Viewer's Settings lists Appearance, SnapShots, People and Open-source licenses, and the licenses page shows the same content on base and head apart from the picker.

Not exercised: a Collaborator's view (same code path as the Viewer's), desktop, other Settings pages besides General, and no agent turn (the change doesn't touch the turn path). j5/main has since moved by #710, which doesn't touch Settings.

Upstream impact

  • apps/web/src/components/settings/SettingsScopeSentence.tsx: one more line in SETTINGS_DEVICE_ONLY_PATHS, recorded in FORK.md case 72's text (the file is already in its table row).

Checklist

  • One concern: the description has no "also"
  • Tests cover the changed behavior (no test: a one-entry list change, which its screenshot shows)
  • UI changes: before/after screenshots above, and a video for motion or interaction
  • Live testing: the section above says what ran live and what did not
  • Upstream-owned files: each one is recorded in FORK.md (case text and file-table row) in this PR
  • Upstream product: any change to what upstream's product does has a human decision linked above and a register entry in docs/j5/product/upstream.md (none: J5's own Settings access, case 72)
  • Surfaces: entry points, clients, providers, contracts, reverse states, connection modes (see AGENTS.md). Web and desktop share this page; mobile has no Settings licenses page
  • Docs: definitions under docs/j5/product/ and user docs rewritten where this changes them (none needed)

Built by Claude Opus 5.5 in Claude Code.

🤖 Generated with Claude Code

The licenses are the same for every server, and since #638 a non-Owner
sees the page, so the Settings server picker did nothing there.

Closes #646

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Oct 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
j5-code Ready Ready Preview Oct 25, 2026 3:47am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 2 billable files and costs up to $0.50.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 8 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 5 included reviews currently available. Your 12 included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between e114f4d and aaf0e05.

Files selected for processing: 2
  • FORK.md
  • apps/web/src/components/settings/SettingsScopeSentence.tsx
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 effective changed lines (test files excluded in mixed PRs). labels Oct 25, 2026
Jacksondr5 added a commit that referenced this pull request Oct 25, 2026
@Jacksondr5
Jacksondr5 merged commit 407c9ca into j5/main Oct 25, 2026
32 checks passed
@Jacksondr5
Jacksondr5 deleted the j5code/licenses-no-server-picker branch October 25, 2026 04:00

This branch was successfully deployed

1 active deployment
Preview — aaf0e05a Deployed Oct 25, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Settings: Open-source licenses shows no server picker

1 participant