Repository navigation
fix(web): Open-source licenses shows no server picker - #712
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
This review includes 2 billable files and costs up to $0.50.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 8 minutes for your next included review. View limit details
Comment |
Jacksondr5
added a commit
that referenced
this pull request
Oct 25, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Settings › Open-source licenses showed the Settings server picker ("Applying settings for …"). The page is the same for every server, so the picker did nothing there. Since #638 a non-Owner sees this page too, so more people saw the picker. Closes #646.
What changed
The licenses path joins
SETTINGS_DEVICE_ONLY_PATHS, the list of pages that show no scope picker, beside Appearance, SnapShots, Connections and People. For a non-Owner, the same list also lets the page through upstream's scope boundary, so the licenses show even when the person owns no server whose scope could be resolved.UI changes
Owner, Settings › Open-source licenses
A Viewer at project scope, the same page
Owner, Settings › General, after: other pages keep the picker.
Live testing
Pass. A tester agent (Claude Sonnet 5.5) ran head
aaf0e05a11against base90e159d0e7with the live-test rig's--basesetup, so both showed the same data. Checked: the Owner and a project-scope Viewer on the licenses page, and the Owner on General. The Viewer's Settings lists Appearance, SnapShots, People and Open-source licenses, and the licenses page shows the same content on base and head apart from the picker.Not exercised: a Collaborator's view (same code path as the Viewer's), desktop, other Settings pages besides General, and no agent turn (the change doesn't touch the turn path).
j5/mainhas since moved by #710, which doesn't touch Settings.Upstream impact
apps/web/src/components/settings/SettingsScopeSentence.tsx: one more line inSETTINGS_DEVICE_ONLY_PATHS, recorded in FORK.md case 72's text (the file is already in its table row).Checklist
FORK.md(case text and file-table row) in this PRdocs/j5/product/upstream.md(none: J5's own Settings access, case 72)AGENTS.md). Web and desktop share this page; mobile has no Settings licenses pagedocs/j5/product/and user docs rewritten where this changes them (none needed)Built by Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code