Skip to content

redesign the help statistics plot #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Neil-Tomar wants to merge 1 commit into
base: main
Choose a base branch
from
Open

redesign the help statistics plot #560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/net/discordjug/javabot/systems/help/commands/HelpAccountSubcommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ private FileUpload generatePlot(User user) {
plotData.add(new Pair<>(position.getMonth() + " " + position.getYear(), new Plotter.Bar(value)));
}

BufferedImage plt = new Plotter(plotData, "gained help XP per month").plot();
BufferedImage plt = new Plotter(plotData, "General Helper XP Gains","XP earned each month from general helper activity").plot();
try(ByteArrayOutputStream os = new ByteArrayOutputStream()){
ImageIO.write(plt, "png", os);
return FileUpload.fromData(os.toByteArray(), "image.png");
Expand Down
35 changes: 20 additions & 15 deletions src/main/java/net/discordjug/javabot/systems/help/commands/HelpStatisticsSubcommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,8 @@
import java.io.ByteArrayOutputStream;
import java.io.IOException;
import java.time.LocalDate;
import java.util.ArrayList;
import java.util.Comparator;
import java.util.HashMap;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
import java.util.*;

@danthe1st danthe1st Sep 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid the wildcard import.

import java.util.Map.Entry;
import java.util.PriorityQueue;

import javax.imageio.ImageIO;

Expand All @@ -24,6 +18,8 @@
import net.discordjug.javabot.util.Plotter;
import net.dv8tion.jda.api.EmbedBuilder;
import net.dv8tion.jda.api.events.interaction.command.SlashCommandInteractionEvent;
import net.dv8tion.jda.api.interactions.commands.OptionMapping;
import net.dv8tion.jda.api.interactions.commands.OptionType;
import net.dv8tion.jda.api.interactions.commands.build.SubcommandData;
import net.dv8tion.jda.api.utils.FileUpload;
import xyz.dynxsty.dih4jda.interactions.commands.application.SlashCommand;
Expand All @@ -34,21 +30,30 @@
public class HelpStatisticsSubcommand extends SlashCommand.Subcommand {

private static final List<Pair<String, Color>> COLORS = List.of(
new Pair<>("Red", Color.RED), new Pair<>("Blue", Color.BLUE), new Pair<>("Yellow", Color.YELLOW),
new Pair<>("Green", Color.GREEN), new Pair<>("Cyan", Color.CYAN), new Pair<>("Magenta", Color.MAGENTA),
new Pair<>("Orange", Color.ORANGE), new Pair<>("Pink", Color.PINK), new Pair<>("Light gray", Color.LIGHT_GRAY)
new Pair<>("Red", Color.decode("#D62728")), new Pair<>("Blue", Color.decode("#1F77B4")), new Pair<>("Yellow", Color.decode("#BCBD22")),
new Pair<>("Green", Color.decode("#2CA02C")), new Pair<>("Cyan", Color.decode("#17BECF")), new Pair<>("Magenta", Color.decode("#9467BD")),
new Pair<>("Orange", Color.decode("#FF7F0E")), new Pair<>("Pink", Color.decode("#E377C2")), new Pair<>("Light gray", Color.decode("#7F7F7F"))
);

private final HelpTransactionRepository transactionRepository;


/**
* Creates the help statistics subcommand.
*
* @param transactionRepository repository for help transactions
*/
public HelpStatisticsSubcommand(HelpTransactionRepository transactionRepository) {
this.transactionRepository = transactionRepository;
setCommandData(new SubcommandData("stats", "Shows an general plot about help activity in this server"));
setCommandData(new SubcommandData("stats", "Shows an general plot about help activity in this server")
.addOption(OptionType.BOOLEAN, "darkmode", "generate a plot in dark mode.", false)

@danthe1st danthe1st Sep 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should start with an uppercase letter. I would suggest

Generates the plot with a dark background.

@Neil-Tomar Neil-Tomar Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean change darkmode to Darkmode?
if yes, it results an IllegalArgumentException exception.

@danthe1st danthe1st Sep 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant that the command description should start with an uppercase letter, not the command name.

);

}

@Override
public void execute(SlashCommandInteractionEvent event) {

boolean darkMode = event.getOption("darkmode", false, OptionMapping::getAsBoolean);

event.deferReply().queue();

List<Pair<MonthInYear,HelpAccount>> transactionWeights = transactionRepository.getTotalTransactionWeightByMonthAndUsers(LocalDate.now().withDayOfMonth(1).minusYears(1).atStartOfDay());
Expand All @@ -75,8 +80,8 @@ public void execute(SlashCommandInteractionEvent event) {
}
plotData.add(new Pair<>(position.getMonth() + " " + position.getYear(), new Plotter.Bar(entriesForThisMonth)));
}
BufferedImage plot = new Plotter(plotData, "General helper statistics").plot();

BufferedImage plot = new Plotter(plotData, "Help Statistics","Monthly assistance provided to community members",darkMode).plot();
try(ByteArrayOutputStream os = new ByteArrayOutputStream()){
ImageIO.write(plot, "png", os);
FileUpload upload = FileUpload.fromData(os.toByteArray(), "image.png");
Expand Down
Loading
Loading