feat: add a Makefile, and name the compose volume jq-fleet-data - #34
Merged
Merged
Conversation
The README's docker run and docker rm -f stay the documented way in; the Makefile is for the machine where you type them often. Every target goes through docker compose, so docker-compose.yml remains the single place the mounts, ports and environment live. What the one-liners leave you to do by hand: - `make up` waits out the collector's first pass over the fleet before opening the board, so you do not land on a page of "No data". - `make status` says whether the collector is past that first pass. - `make preflight` catches the three ways a start fails before a container moves, including a hand-started jq-fleet that compose cannot adopt. Name the compose volume jq-fleet-data as well. Compose would otherwise call it jq-monitoring_fleet-data while the README's docker run writes to jq-fleet-data - two names is two histories, and bringing the board up the other way once would start every panel from empty. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README's
docker runanddocker rm -fstay the documented way in. The Makefile is for the machine where you type them often enough to mistype them.Every target goes through
docker compose, sodocker-compose.ymlstays the one place the mounts, ports and environment live — no second copy of-vand-eto keep in step.What the one-liners leave you to do by hand
make upwaits out the collector's first pass over the fleet before opening the board. The container is healthy as soon as Grafana answers, but:9109stays shut until both sources are seeded — so without the wait you land on a page ofNo data.make statussays whether the collector is past that first pass, rather than just whether something is running.make preflightcatches the three ways a start fails before a container moves. The third is worth the lines: ajq-fleetstarted by hand carries no compose labels, so compose will not adopt it and stops atcontainer name already in use.make purge REPO=owner/nameandmake cleanare both irreversible;cleanasks for a typedyesfirst.The volume name
Compose would otherwise call the volume
jq-monitoring_fleet-datawhile the README'sdocker runwrites tojq-fleet-data. Two names is two histories: bring the board up the other way once and every panel starts from empty, with the real history still on disk under a name nothing reads. Naming it outright means one volume, either way in.Testing
Untested end to end —
make upandmake cleanhave not been run against a live Docker daemon on this branch. Worth a smoke test before merging.🤖 Generated with Claude Code