Fix MaxOutputTokens to prevent runaway generation dominating bill and… - #4
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR applies a per-invocation MaxOutputTokens cap when running ChatClientAgent calls to prevent a single agent turn from generating excessive output that dominates cost and increases latency.
Changes:
- Store
chatOptions.MaxOutputTokensper agent instance. - Pass
ChatClientAgentRunOptionswithMaxOutputTokenson eachRunAsync/RunAsync<T>invocation. - Apply the cap consistently across Author/Researcher/Reviewer/Blogger agents.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ReviewerAgent.cs | Applies per-run MaxOutputTokens cap for review turns. |
| ResearcherAgent.cs | Applies per-run MaxOutputTokens cap for research runs (including tool-calling). |
| BloggerAgent.cs | Applies per-run MaxOutputTokens cap for structured decision generation. |
| AuthorAgent.cs | Applies per-run MaxOutputTokens cap for drafting/revision turns. |
Comment on lines
+74
to
76
| AgentResponse response = await _agent.RunAsync(message, options: runOptions); | ||
| string content = response.Text; | ||
| return !string.IsNullOrEmpty(content) ? content : "APPROVED"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… latency