switched from config.json to secrets - #7
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the local config.json-based configuration flow and switches the app to read secrets from .NET user-secrets and/or environment variables, aligning local development with CI/production secret management.
Changes:
- Documented the new configuration approach (user-secrets + environment variables) in
README.md. - Replaced
config.jsonparsing withMicrosoft.Extensions.Configurationproviders inProgram.cs. - Added
UserSecretsIdand configuration provider package references in the project file.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| README.md | Adds setup instructions for user-secrets and environment variables; clarifies config.json is no longer used. |
| Program.cs | Switches to ConfigurationBuilder and uses required-key retrieval for OpenAI/Tavily configuration. |
| BlogWriter.csproj | Enables user-secrets for the project and adds required configuration packages. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+18
to
+20
| string GetRequired(string key) => | ||
| config[key] ?? throw new InvalidOperationException( | ||
| $"Missing configuration value '{key}'. Set it with: dotnet user-secrets set \"{key}\" \"<value>\""); |
Comment on lines
+11
to
+16
| // Secrets come from the .NET user-secrets store in development and from | ||
| // environment variables in CI/production (env vars win on key collisions). | ||
| IConfiguration config = new ConfigurationBuilder() | ||
| .AddUserSecrets<Program>() | ||
| .AddEnvironmentVariables() | ||
| .Build(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.