Clean up - #8
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR performs small cleanup/robustness tweaks across the blog-writing workflow, focused on token-budget enforcement and reviewer error handling, plus minor comment edits in the entrypoint.
Changes:
- Add validation for the configured total token cap in
TokenCapChatClient. - Refactor reviewer error handling into a helper and avoid default-approving on empty agent output.
- Update/trim configuration and middleware comments in
Program.cs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| TokenCapChatClient.cs | Adds runtime validation around the global token budget enforcement. |
| ReviewerAgent.cs | Adjusts revision-cap behavior and consolidates error handling for review failures/empty output. |
| Program.cs | Updates comments describing configuration sources and middleware behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
57
to
60
| if (revisionNum >= ResearchState.MaxRevisions) | ||
| { | ||
| return "Uh oh - Maximum revisions reached."; | ||
| return "APPROVED - Maximum revisions reached."; | ||
| } |
Comment on lines
+56
to
+59
| if (maxTotalTokens <= 0) | ||
| { | ||
| throw new InvalidOperationException("Token cap must be a positive number."); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up various minor issues