Skip to content

Fix ascii_local_part/smtputf8 after NFC normalization of local part #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
faresrafat3 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix ascii_local_part/smtputf8 after NFC normalization of local part #186

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a78ada
Fix ascii_local_part/smtputf8 after NFC normalization of local part
faresrafat3 Nov 2, 2026
500465a
Fix quoted local parts after NFC normalization (review finding)
faresrafat3 Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 30 additions & 6 deletions email_validator/validate_email.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,15 +120,39 @@ def validate_email(
# data, and I don't know whether the rules really apply in the wild.)
normalized_local_part = unicodedata.normalize("NFC", ret.local_part)
if normalized_local_part != ret.local_part:
# If the original local part was quoted, NFC normalization keeps
# the surrounding quotes. Unquote before re-validating so that
# validate_email_local_part (which expects an unquoted value and
# re-quotes it when quoted_local_part is True) does not double-escape.
if (is_quoted_local_part and len(normalized_local_part) >= 2
and normalized_local_part[0] == '"' and normalized_local_part[-1] == '"'):
to_validate = ""
escaped = False
for c in normalized_local_part[1:-1]:
if escaped:
to_validate += c
escaped = False
elif c == "\\":
escaped = True
else:
to_validate += c
revalidate_quoted = True
else:
to_validate = normalized_local_part
revalidate_quoted = is_quoted_local_part
try:
validate_email_local_part(normalized_local_part,
allow_smtputf8=allow_smtputf8,
allow_empty_local=allow_empty_local,
quoted_local_part=is_quoted_local_part,
strict=strict)
normalized_local_part_info = validate_email_local_part(
to_validate,
allow_smtputf8=allow_smtputf8,
allow_empty_local=allow_empty_local,
quoted_local_part=revalidate_quoted,
strict=strict,
)
except EmailSyntaxError as e:
raise EmailSyntaxError("After Unicode normalization: " + str(e)) from e
ret.local_part = normalized_local_part
ret.local_part = normalized_local_part_info["local_part"]
ret.ascii_local_part = normalized_local_part_info["ascii_local_part"]
ret.smtputf8 = normalized_local_part_info["smtputf8"]

# If a quoted local part isn't allowed but is present, now raise an exception.
# This is done after any exceptions raised by validate_email_local_part so
Expand Down