add LPV estimation method - #197
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #197 +/- ##
==========================================
+ Coverage 89.25% 89.56% +0.30%
==========================================
Files 14 15 +1
Lines 2466 2692 +226
==========================================
+ Hits 2201 2411 +210
- Misses 265 281 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Documenter evaluates @example blocks at module top-level, where the soft-scope rule makes `x = ... * x + ...` inside a for-loop create a new uninitialized local that shadows the outer `x = zeros(2)`. Wrapping each simulation in a let-block gives the loop hard scope and unblocks the docs build. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* Refactor the loss into _lpv_dataset_predloss so both single- and multi-dataset paths share the inner LTV timestepping loop. * New lpv_pem(ds, λs, nx; ...) and lpv_warmstart(ds, λs, nx; ...) methods that jointly fit θ and K across a vector of experiments while keeping a per-experiment initial state x0::Matrix of shape (nx, length(ds)). * Single-dataset methods now delegate to the multi-dataset implementation and unwrap x0 to a Vector — backward-compatible. * Validate matching Ts/nu/ny across datasets (same as arx, era). * Add test_lpv "LPV PEM multi-dataset" verifying joint fit, x0 shape, per-dataset prediction MSE, and joint-beats-single comparison. * Mark LPVStateSpace, lpv_pem, lpv_warmstart, and the docs example with !!! warning "Experimental" admonitions matching the existing style used for nonlinear_pem in src/pem.jl:633. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
A narrative comment between the docstring closing `"""` and the `function lpv_pem(...)` definition broke the docstring binding so Documenter could not resolve [`lpv_pem`](@ref) anywhere. Drop the comment. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.