Skip to content

Mark JLArray reverse tests broken with JLArrays 0.4.2 and GPUArrays 12.1.1 #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devmotion merged 1 commit into from
Oct 16, 2026
Merged

Mark JLArray reverse tests broken with JLArrays 0.4.2 and GPUArrays 12.1.1 #849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions test/rulesets/Base/array.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,8 +276,14 @@ end
@test_skip test_rrule(reverse, Tuple(rand(10))) # Ambiguity in isapprox, https://github.com/JuliaDiff/ChainRulesTestUtils.jl/issues/229
end
@testset "Array" begin
# JLArrays ≥ 0.4 implements `reverse` without scalar indexing
jl_has_reverse = parentmodule(reverse, Tuple{JLArray{Float32,1}}) !== Base
# `reverse(::JLArray)` fails with JLArrays < 0.4 (scalar indexing) and with
# JLArrays 0.4.2 and GPUArrays 12.1.1, which calls AcceleratedKernels whose kernels
# are unavailable on JLArrays' backend (JuliaGPU/GPUArrays.jl#817)
jl_has_reverse = try
reverse(JLArray([1.0f0, 2.0f0])) isa JLArray
catch
false
end

# Forward
if jl_has_reverse
Expand Down
Loading