Use LinearAlgebra.BLAS.liblapack instead of Base.liblapack_name - #166
Merged
lostella merged 1 commit intoSep 29, 2026
Merged
Conversation
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
staticfloat
approved these changes
Sep 29, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #166 +/- ##
==========================================
+ Coverage 94.33% 94.37% +0.03%
==========================================
Files 80 80
Lines 2596 2596
==========================================
+ Hits 2449 2450 +1
+ Misses 147 146 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lostella
approved these changes
Sep 29, 2026
lostella
left a comment
Member
There was a problem hiding this comment.
Thank you so much @greekera1000!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Julia nightly,
dspev!anddspevV!segfault when calling LAPACK. They useccallwithBase.liblapack_name, which on nightly loads libblastrampoline without connecting it to OpenBLAS, so the LAPACK function pointer is null.This PR replaces
Base.liblapack_namewithLinearAlgebra.BLAS.liblapackin both calls. That loads libblastrampoline the proper way on nightly, and it exists in every Julia version since 1.0, so older versions are unaffected. Julia maintainers are also planning to remove or deprecateBase.libblas_name/liblapack_name, so this moves the package off them ahead of time.See the upstream discussion in JuliaLang/julia#63432. where @staticfloat suggested to update package will be a helpfull work
Tested on Julia nightly and 1.12.x: all tests pass.
disclosure : claude helped