Skip to content

Add JET workflow - #358

Merged
kimikage merged 1 commit into
JuliaMath:masterfrom
kimikage:add_jet_workflow
Oct 17, 2026
Merged

kimikage merged 1 commit into
JuliaMath:masterfrom
kimikage:add_jet_workflow

Conversation

@kimikage

@kimikage kimikage commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

This is the workflow (GitHub Actions) version of PR #324.

CC: @PatrickHaecker

@codecov

codecov Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.22%. Comparing base (6decae1) to head (ca203be).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #358   +/-   ##
=======================================
  Coverage   97.22%   97.22%           
=======================================
  Files           7        7           
  Lines         792      792           
=======================================
  Hits          770      770           
  Misses         22       22           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kimikage
kimikage marked this pull request as draft October 15, 2026 01:05
@kimikage
kimikage force-pushed the add_jet_workflow branch 2 times, most recently from f6fc589 to b7d746b Compare October 15, 2026 01:26
@kimikage
kimikage marked this pull request as ready for review October 15, 2026 06:14
@kimikage kimikage added ci Continuous integration github_actions Pull requests that update GitHub Actions code labels Oct 15, 2026

@PatrickHaecker PatrickHaecker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend to implement the two suggested changes. The PR otherwise looks good to me.

Comment thread .github/workflows/JET.yml Outdated
Comment thread .github/workflows/JET.yml Outdated
Comment on lines +49 to +56
run: julia --project=. --color=yes -e '
using JET, Test;
using FixedPointNumbers;
println("report_package(FixedPointNumbers, toplevel_logger=nothing)");
show(JET.report_package(FixedPointNumbers, toplevel_logger=nothing));
@testset "JET" begin
JET.test_package(FixedPointNumbers; target_modules=(FixedPointNumbers,));
end'

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run: julia --project=. --color=yes -e '
using JET, Test;
using FixedPointNumbers;
println("report_package(FixedPointNumbers, toplevel_logger=nothing)");
show(JET.report_package(FixedPointNumbers, toplevel_logger=nothing));
@testset "JET" begin
JET.test_package(FixedPointNumbers; target_modules=(FixedPointNumbers,));
end'
run: |
julia --project=. --color=yes -e '
using JET, Test, FixedPointNumbers
@testset "JET" begin
JET.test_package(FixedPointNumbers; target_modules=(FixedPointNumbers,))
end'

report_package analyzes the package a second time. Without target_modules, it also lists reports from other modules, and those do not affect the result. When test_package fails, it already prints the reports that caused the failure.

The | block, keeps the newlines, so no trailing semicolons are needed improving readability.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it might be helpful to include potential issues as reference information.
If you feel it's annoying, I'll remove it.

@kimikage

Copy link
Copy Markdown
Collaborator Author

While there is room for improvement, I think it’s best to try using it first.
Since it doesn’t affect the main source code or package testing, we can make changes regardless of the package’s release schedule.

@kimikage
kimikage merged commit f979b14 into JuliaMath:master Oct 17, 2026
15 checks passed
@kimikage
kimikage deleted the add_jet_workflow branch October 17, 2026 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous integration github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants